Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dark Mode Toggle Button #340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sarthakkashyapp
Copy link
Contributor

What does this PR do?

Added the Dark mode toggle button into the website

Fixes # 57

How should this be tested?

this can be tested by switching on dark mode from navbar.

Checklist

Required

  • [ ☑️ ] Filled out the "How to test" section in this PR
  • [ ☑️ ] Read Contributing guide
  • [ ☑️ ] Self-reviewed my own code
  • [ ☑️ ] Checked for warnings, there are none
  • [ ☑️ ] Removed all console.logs
  • [ ☑️ ] The changes don't cause any responsiveness issues

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for delightful-daifuku-a9f6ea ready!

Name Link
🔨 Latest commit b2c4ab8
🔍 Latest deploy log https://app.netlify.com/sites/delightful-daifuku-a9f6ea/deploys/671a8338834bbf0008662a93
😎 Deploy Preview https://deploy-preview-340--delightful-daifuku-a9f6ea.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AlfiyaSiddique
Copy link
Owner

@Sarthakkashyapp the texts are not readable:
image

Make all text readable and the recipe card background white as well

@AlfiyaSiddique
Copy link
Owner

In navbar profile and bell icon text color becomes white in dark mode make it as it is in white mode

@AlfiyaSiddique
Copy link
Owner

@Sarthakkashyapp are you up for this issue

@Sarthakkashyapp
Copy link
Contributor Author

@Sarthakkashyapp are you up for this issue

@AlfiyaSiddique I was not feeling good will try to do it today or tomorrow

@AlfiyaSiddique
Copy link
Owner

Okay fine, but to remind you that the points will not be counted as the event will end today at 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants